fix(spinner): ensure transform doesn't overwrite circular animation#24643
Merged
averyjohnston merged 2 commits intomainfrom Jan 24, 2022
Merged
fix(spinner): ensure transform doesn't overwrite circular animation#24643averyjohnston merged 2 commits intomainfrom
averyjohnston merged 2 commits intomainfrom
Conversation
sean-perkins
approved these changes
Jan 24, 2022
This was referenced Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: Resolves #19247
When a CSS
transformis applied to anion-spinnerof typecircular, the spinner slides down and to the right during its animation. (This only happens with this particular combination, not necessarily withposition: absoluteas the issue notes, or with any other spinner types.)What is the new behavior?
The
animationnow applies to the internalsvg, not the host. This way, an appliedtransformwon't overwrite parts of the animation keyframes.Does this introduce a breaking change?
Other information
The
circularspinner was introduced in Ionic 4.8.x and is the default formdmode.