Skip to content

fix(spinner): ensure transform doesn't overwrite circular animation#24643

Merged
averyjohnston merged 2 commits intomainfrom
FW-385
Jan 24, 2022
Merged

fix(spinner): ensure transform doesn't overwrite circular animation#24643
averyjohnston merged 2 commits intomainfrom
FW-385

Conversation

@averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Resolves #19247

When a CSS transform is applied to an ion-spinner of type circular, the spinner slides down and to the right during its animation. (This only happens with this particular combination, not necessarily with position: absolute as the issue notes, or with any other spinner types.)

What is the new behavior?

The animation now applies to the internal svg, not the host. This way, an applied transform won't overwrite parts of the animation keyframes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

The circular spinner was introduced in Ionic 4.8.x and is the default for md mode.

@averyjohnston averyjohnston requested a review from a team January 24, 2022 19:25
@github-actions github-actions bot added the package: core @ionic/core package label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-spinner moving when position absolute (possible regression)

2 participants